Docs: Fix indentation in slice class of functions.rst #134393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paragraph should not be under `slice.step`. It applies to the whole class.
|
All commit authors signed the Contributor License Agreement. |
bedevere-app
bot
added
docs
ZeroIntensity
approved these changes
May 20, 2025
ZeroIntensity
added
needs backport to 3.13
|
The change looks wrong. |
|
What's wrong with it? That paragraph renders pretty weirdly on the current documentation. |
|
The paragraph describes start, step and stop attributes, so I think that the current doc is correct. No? |
|
Eh, it looks a little funny to me, particularly because it reads as being exclusive to |
|
+1 for moving the paragraph above start/end/step. Should I commit that change? |
|
Sorry for the late response. Go for it. |
|
Thanks @reynoldsnlp for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 25, 2025
…34393) Paragraph should not be under `slice.step`. It applies to the whole class. --------- (cherry picked from commit 6227662) Co-authored-by: Rob Reynolds <[email protected]> Co-authored-by: Rob Reynolds <[email protected]>
|
GH-135948 is a backport of this pull request to the 3.14 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 25, 2025
…34393) Paragraph should not be under `slice.step`. It applies to the whole class. --------- (cherry picked from commit 6227662) Co-authored-by: Rob Reynolds <[email protected]> Co-authored-by: Rob Reynolds <[email protected]>
|
GH-135949 is a backport of this pull request to the 3.13 branch. |
|
Congrats on your first contribution @reynoldsnlp :) |
ZeroIntensity
pushed a commit
that referenced
this pull request
Jun 25, 2025
…134393) (GH-135949) Docs: Fix indentation in `slice` class of `functions.rst` (GH-134393) Paragraph should not be under `slice.step`. It applies to the whole class. (cherry picked from commit 6227662) Co-authored-by: Rob Reynolds <[email protected]>
ZeroIntensity
pushed a commit
that referenced
this pull request
Jun 25, 2025
…134393) (#135948) Docs: Fix indentation in `slice` class of `functions.rst` (GH-134393) Paragraph should not be under `slice.step`. It applies to the whole class. (cherry picked from commit 6227662) Co-authored-by: Rob Reynolds <[email protected]>
AndPuQing
pushed a commit
to AndPuQing/cpython
that referenced
this pull request
Jul 11, 2025
…34393) Paragraph should not be under `slice.step`. It applies to the whole class. --------- Co-authored-by: Rob Reynolds <[email protected]>
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…34393) Paragraph should not be under `slice.step`. It applies to the whole class. --------- Co-authored-by: Rob Reynolds <[email protected]>
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…34393) Paragraph should not be under `slice.step`. It applies to the whole class. --------- Co-authored-by: Rob Reynolds <[email protected]>
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…34393) Paragraph should not be under `slice.step`. It applies to the whole class. --------- Co-authored-by: Rob Reynolds <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paragraph should not be under
slice.step. It applies to the whole class.📚 Documentation preview 📚: https://cpython-previews--134393.org.readthedocs.build/en/134393/library/functions.html#slice